BUG: Raise on coercion of ambiguous datetime strings to datetime64 #61489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The This PR imports Happy to refactor this if needed, for example, by moving it to a shared utility module or discussing exposing it publicly if that makes more sense long-term |
|
Closing this PR as the current approach doesn’t feel quite right from a design and maintainability perspective. I believe there might be a cleaner solution that avoids adding complexity across multiple layers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a bug where object-dtype arrays containing ambiguous datetime strings (e.g.,
"12/01/2020","13/01/2020") were being silently coerced todatetime64[ns], potentially resulting in inconsistent or unintended parsing.Introduced stricter input validation during coercion to detect and raise a
ValueErrorwhen an ambiguous format is inferred but cannot be consistently parsed.Added tests to cover both direct assignment and constructor-based coercion scenarios.
closes 61353
Tests added and passed
All code checks passed
Added an entry in the latest
doc/source/whatsnew/v3.0.0.rstfile